Skip to content

feat(oauth): polished success page for Google auth callback#2

Open
salmonumbrella wants to merge 1 commit intoRoamJS:mainfrom
salmonumbrella:oauth-success-page-visual-upgrade
Open

feat(oauth): polished success page for Google auth callback#2
salmonumbrella wants to merge 1 commit intoRoamJS:mainfrom
salmonumbrella:oauth-success-page-visual-upgrade

Conversation

@salmonumbrella
Copy link
Copy Markdown

Summary

  • Upgrades the OAuth callback page (/oauth) from plain text to a branded success screen
  • Adds RoamJS logo with checkmark badge, fade-in animation, and a Roam-themed cursor badge
  • All existing OAuth relay logic is preserved unchanged: trusted-origin postMessage, session POST with error propagation, auto-close behavior

Context

Originally proposed in RoamJS/google#37 but that PR targeted the wrong repo. This PR applies the visual upgrade directly to the live page in the website repo, addressing the review feedback from @mdroidian:

  • Trusted origins: Existing postMessage logic with origin whitelist is preserved (no wildcard *)
  • Full param relay: All URL params are forwarded via JSON.stringify(params) (not just code+state)
  • Desktop error propagation: Session POST includes error/error_description — unchanged

Test plan

  • Open /oauth?auth=true locally to verify the visual design renders correctly
  • Test full Google OAuth login flow in browser (popup flow)
  • Test desktop app flow (session polling path)
  • Verify postMessage only targets trusted origins (inspect network/console)

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 31, 2026

@salmonumbrella is attempting to deploy a commit to the mdroidian's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 80b144c3-6162-495b-9573-93f34f03fb08

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant